Fix utils::copy_file for symlink.
#1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping. |
2 similar comments
|
Ping. |
|
Ping. |
|
@alexcrichton, anything I can do to move this along? |
|
@reitermarkus unfortunately rustup doesn't have a lot of active development and I don't personally have enough time to take a deep dive here to see if this is the correct fix or not (or what sort of unintended fallout this might have) |
|
@alexcrichton, no worries. For what it's worth, this patch has been integrated into the Homebrew package for a month now without any bug reports, if that is any indication on correctness. |
|
Given this fixes an issue that is affecting several people and seems to be working for Homebrew, I'm going to merge this. Thanks for the PR @reitermarkus ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
rustup-initis a symlink, create a symlink to that symlink instead of resolving it first. This is also in line with using theno-self-updatefeature, to allow managing therustupversion with Homebrew.Fixes #1512.