Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes a bug with trailing newlines in toolchain path. #19

Closed
wants to merge 1 commit into from
Closed

Fixes a bug with trailing newlines in toolchain path. #19

wants to merge 1 commit into from

Conversation

norcalli
Copy link

I was getting the following error when running cargo.

error: not a directory: '/Users/ashkan/.multirust/toolchains/stable
'

and noticed that the quote goes to the next line, so I added a trim to the
toolchain constructor for the only part that seemed to be problematic. Possibly
not the best solution, but it fixed my issue.

@Diggsey
Copy link
Contributor

Diggsey commented Oct 27, 2015

Hi @norcalli, thanks for the pull request. However, I'd prefer to fix this at the source.

I've pushed a new version which trims newlines when reading the default toolchain. Could you tell me if that fixes the problem?

Also, could you show me what you did to get this to occur, so I can add a regression test?

@norcalli
Copy link
Author

It does seem to have fixed the problem after running cargo build, then rm ~/.multirust/bin/multirust and finally ./target/release self install, which I hope is the appropriate way to reinstall.

The exact steps I took to recreate this was to simply pull the lettre crate into my ~/Workspace/projects/lettre folder and then attempt to run cargo after installing multirust-rs. I was using the regular multirust before, so perhaps it has something to do with that.

If you have a suggestion on where to look for what could have caused this, I'm all ears.

@Diggsey
Copy link
Contributor

Diggsey commented Oct 28, 2015

@norcalli Ah thanks, it was exactly as I'd suspected: the original multirust puts a newline in the "default" file, whereas multirust-rs doesn't. Simply trimming the result after reading that file was sufficient.

(Yep, that's the correct way to reinstall from source - you can also just do multirust self update to magically download and install updated binaries!)

@Diggsey Diggsey closed this Oct 28, 2015
djc added a commit that referenced this pull request Jun 18, 2024
# This is the 1st commit message:

Port cli_inst_interactive to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #20 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #21 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #22 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #23 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #24 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #25 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #26 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #27 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #28 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #29 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #30 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #31 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #32 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #33 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #34 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #35 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #36 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #37 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #38 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #39 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext

# The commit message #40 will be skipped:

# fixup! Port cli_inst_interactive to CliTestContext
djc added a commit that referenced this pull request Jun 18, 2024
# This is the 1st commit message:

Port cli_misc to CliTestContext

# The commit message #2 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #3 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #4 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #5 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #6 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #7 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #8 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #9 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #10 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #11 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #12 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #13 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #14 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #15 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #16 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #17 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #18 will be skipped:

# fixup! Port cli_misc to CliTestContext

# The commit message #19 will be skipped:

# fixup! Port cli_misc to CliTestContext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants