Fixing janky line breaks in self_updater.rs #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing janky line breaks in the %USERPROFILE% path help string, as reported in rust-lang#2334
|
Did this come from #2336 ? if so, why not just update that MR. As a rustup committer you should have had the rights. |
That capability is able to be turned on and off on a per PR basis... yes it is that PR rebased. I'm not sure how to update that PR. |
|
If you can, it'll say near the bottom of the page (above the checks/merge box) 'Add more commits by pushing to ...' |
|
OOI did this get done somewhere, or should we merge this? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing janky line breaks in the %USERPROFILE% path help string, as reported in #2334