Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macOS aarch-64 xcode-select directory. #2877

Merged
merged 1 commit into from Oct 25, 2021
Merged

Remove macOS aarch-64 xcode-select directory. #2877

merged 1 commit into from Oct 25, 2021

Conversation

wcarss
Copy link
Contributor

@wcarss wcarss commented Oct 21, 2021 •
edited

12.2 is likely out of date, and it is breaking PR builds. It likely
isn't required to use the beta compiler anymore[1], so we'll just remove
the line altogether. specify xcode 13.0 and SDK 11.3.

1 - see this version table on wikipedia

If successful, fixes #2875.

@wcarss wcarss force-pushed the fix-macos-pr-build-xcode-directory branch from de9e5f8 to c0613e4 Compare October 21, 2021 17:51
@wcarss
Copy link
Contributor Author

wcarss commented Oct 21, 2021

I don't think removing it is correct. The build (despite getting past this stage) now reports:

xcodebuild: error: SDK "macosx11.0" cannot be located.
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcrun: error: unable to lookup item 'Path' in SDK 'macosx11.0'
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcodebuild: error: SDK "macosx11.0" cannot be located.
xcrun: error: unable to lookup item 'PlatformVersion' in SDK 'macosx11.0'

so I'll try adding it back in and referencing Xcode 13.0, the current version.

@wcarss
Copy link
Contributor Author

wcarss commented Oct 21, 2021

Looks like specifying xcode 13.0 and sdk 11.3 did it, but I suspect that not specifying either would also work from now on and be less fragile across future xcode/SDK releases.

Someone who actually has an M1 might want to sanity-check this before it merges! I'm just a pattern-matching dog who tries numbers out until lights go green. 🐕

@ehuss
Copy link
Contributor

ehuss commented Oct 21, 2021

fwiw, in the rust-lang/rust repository, it was chosen to just remove the explicit xcode select in rust-lang/rust#89849.

@wcarss
Copy link
Contributor Author

wcarss commented Oct 21, 2021

ah, thanks for the context @ehuss! I'll replace these with one where the sdk and xcode specifics are all dropped.

Not sure what the issue might be with that windows-build permissions problem /shrug

@wcarss
Drop aarch64-apple-darwin build xcode+sdk lines.
7e55850 
Xcode 12.2 is likely out of date, and it is breaking PR builds since
the latest mac image bumped to 13.0. Xcode 13.0 uses SDK 11.3 by
default, so we shouldn't need to specify the SDK any longer either,
and not specifying the precise versions ought to be less fragile.
@wcarss wcarss force-pushed the fix-macos-pr-build-xcode-directory branch from 6093af9 to 7e55850 Compare October 21, 2021 19:02
kinnison
kinnison approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@kinnison kinnison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this

@kinnison kinnison merged commit 59de864 into rust-lang:master Oct 25, 2021
@wcarss wcarss mentioned this pull request Nov 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kinnison kinnison kinnison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PR Builds for macOS aarch64 failing due to xcode-select directory
3 participants
@wcarss @ehuss @kinnison