Add support for SO_ORIGINAL_DST and IP6T_SO_ORIGINAL_DST. #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those values contain the original destination IPv4/IPv6 address of the connection redirected using iptables REDIRECT or TPROXY. Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
|
Could also add a test, even if it's ignored by default. |
Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
Signed-off-by: Piotr Sikora <piotr@aviatrix.com>
Done. |
PiotrSikora
commented
Dec 3, 2022
Thomasdezeeuw
approved these changes
Dec 4, 2022
| fn original_dst() { | ||
| let socket = Socket::new(Domain::IPV4, Type::STREAM, None).unwrap(); | ||
| match socket.original_dst() { | ||
| Ok(_) => panic!("original_dst on non-redirected socket should fail"), |
There was a problem hiding this comment.
How difficult would it be to add a test that successfully retrieved the address?
There was a problem hiding this comment.
You'd need to configure iptables redirect in the operating system, which seems invasive for a test of the bindings.
|
Thanks @PiotrSikora. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those values contain the original destination IPv4/IPv6 address
of the connection redirected using iptables REDIRECT or TPROXY.
Signed-off-by: Piotr Sikora piotr@aviatrix.com