Fix compilation on Windows #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was cherry-pick picked from the v0.5 branch, but never compiled properly due changed made to v0.5. Combine that with a broken CI, which we didn't know about, and you've got a broken v0.4.8 release.
Darksonn
approved these changes
Mar 3, 2023
Cargo hack uses a newer Rust version than our MSRV, so manually installing it is becoming a pain.
|
Thanks @Thomasdezeeuw! Sorry for the compilation error, I didn't have the time to test it on a Windows PC before it was merged. I noticed the |
|
No problem. Yes GitHub Actions weren't run, only our Circle CI, thus reporting a green CI without actually doing all of the checks. The first commit in this pr first that as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was cherry-pick picked from the v0.5 branch, but never compiled
properly due changed made to v0.5. Combine that with a broken CI, which
we didn't know about, and you've got a broken v0.4.8 release.
Fixes #408