Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize AArch64 AES/SHA1/SHA2 intrinsics #1399

Merged
merged 1 commit into from
May 25, 2023

Conversation

Amanieu
Copy link
Member

@Amanieu Amanieu commented Mar 23, 2023

These have been tested against the equivalent Clang intrinsics with random inputs.

@rustbot
Copy link
Collaborator

rustbot commented Mar 23, 2023

@Amanieu: no appropriate reviewer found, use r? to override

@Amanieu
Copy link
Member Author

Amanieu commented Mar 23, 2023

@rfcbot fcp merge

@rfcbot
Copy link

rfcbot commented Mar 23, 2023

Team member @Amanieu has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@rfcbot
Copy link

rfcbot commented May 14, 2023

🔔 This is now entering its final comment period, as per the review above. 🔔

psst @Amanieu, I wasn't able to add the final-comment-period label, please do so.

@rfcbot
Copy link

rfcbot commented May 24, 2023

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

psst @Amanieu, I wasn't able to add the finished-final-comment-period label, please do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants