Split aarch64 pauth feature into paca and pacg
#1259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust-highfive has picked a reviewer for you, use r? to override) |
|
LGTM, but the feature names in rustc also need to be adjusted since the macro also checks for |
|
Thanks, I didn't realise the two were coupled like that |
adamgemmell
force-pushed
the
dev/split-pauth
branch
from
80638ca
to
8c285bf
Compare
|
This is still blocked on getting these features split on the rustc side. |
|
This needs a rebase due to a conflict with #1239. |
|
☔ The latest upstream changes (presumably 00aa60a) made this pull request unmergeable. Please resolve the merge conflicts. |
adamgemmell
force-pushed
the
dev/split-pauth
branch
from
8c285bf
to
4d31a8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion on rust-lang/rust#86941, this is consistent with Linux and in the future there may well be environments with only one of address authentication or generic code authentication available.