Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LoongArch SIMD intrinsics #1535

Merged
merged 6 commits into from Feb 28, 2024
Merged

Add LoongArch SIMD intrinsics #1535

merged 6 commits into from Feb 28, 2024

Conversation

heiher
Copy link
Contributor

@heiher heiher commented Feb 20, 2024

This PR adds LoongArch SIMD (LSX/LASX) intrinsics and testcases.

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Amanieu (or someone else) some time within the next two weeks.

Amanieu
Amanieu reviewed Feb 20, 2024
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the tests also automatically generated, or just the intrinsic definitions?

crates/stdarch-gen/src/main.rs Outdated Show resolved Hide resolved
@heiher
Copy link
Contributor Author

heiher commented Feb 21, 2024

Are the tests also automatically generated, or just the intrinsic definitions?

The tests are also automatically generated, but not by this generator.

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2024

Can you also include the generator used for making the tests? I don't want to include any auto-generated code in this repo without also including the generator used to create it.

Finally, can you also commit a copy of the header files used to generate the .spec files?

@heiher heiher marked this pull request as draft February 26, 2024 03:24
@heiher heiher marked this pull request as ready for review February 27, 2024 13:17
@heiher
Copy link
Contributor Author

heiher commented Feb 27, 2024

Can you also include the generator used for making the tests? I don't want to include any auto-generated code in this repo without also including the generator used to create it.

Finally, can you also commit a copy of the header files used to generate the .spec files?

Thanks for your review. I have updated the patch to include code for generating test cases and also added copying of header files.

Amanieu
Amanieu approved these changes Feb 27, 2024
View reviewed changes
Copy link
Member

@Amanieu Amanieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Just a few minor changes and this is good to merge.

crates/core_arch/src/loongarch64/lasx/mod.rs Show resolved Hide resolved
crates/stdarch-gen-loongarch/README.md Outdated Show resolved Hide resolved
xiangzhai and others added 5 commits February 28, 2024 09:30
@Amanieu Amanieu merged commit 7d7351a into rust-lang:master Feb 28, 2024
27 checks passed
@heiher heiher mentioned this pull request Feb 28, 2024
Open
@heiher heiher deleted the std-simd-la64 branch February 28, 2024 09:20
@xiangzhai xiangzhai mentioned this pull request Feb 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu approved these changes

Assignees

@Amanieu Amanieu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@heiher @rustbot @Amanieu @xiangzhai