Fix std_detect_env_override
feature on Windows by avoiding libc
#1571
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #1563, the only dependency on
libc
when buildingstdarch
for Windows was a call togetenv
when thestd_detect_env_override
feature was enabled. Since thelibc
dependency is only enabled for non-Windows platforms, enabling thestd_detect_env_override
feature on Windows would cause a build break.This change replaces the use of
getenv
with a call toGetEnvironmentVariableA
on Windows and enables testing thestd_detect_env_override
feature.Fixes #1563
r? @ChrisDenton