Add VAES intrinsics #942
Merged
Add VAES intrinsics #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Amanieu (rust_highfive has picked a reviewer for you, use r? to override) |
This adds support for the x86-64 VAES (vectorized AES) intrinsics. It adds in both the full-width and the VL'ed 256-bit versions and ensures via tests that they match the same test vectors as the AES-NI versions and that they match (though sadly w/o quickcheck validation for now)
This simplifies the test code for VAES by replacing the repeated identical setup for a and k with a function call and by using broadcasts instead of manual value repetitions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the x86-64 VAES (vectorized AES) intrinsics.
It adds in both the full-width and the VL'ed 256-bit versions
and ensures via tests that they match the same test vectors as the AES-NI
versions and that they match (though sadly w/o quickcheck validation for now)
The test vectors used are the same as in aes.rs.
The folder was chosen to match that of the AVX512F (+-IFMA) implementation.
The name is chosen because of how it is detected in Rust.
This PR requires rust-lang/rust#78361 to be applied to the compiler for the compiler to accept the
avx512vaesfeature.I have marked this PR as a draft until the compiler is updated and the change landed in nightly.