Avoid double-pinging Zulip when opening a MCP

rust-lang · Jun 29, 2020 · 08e7618 · 08e7618
1 parent 60f6f91
commit 08e7618
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/src/handlers/major_change.rs b/src/handlers/major_change.rs
@@ -52,7 +52,17 @@ impl Handler for MajorChangeHandler {
                     {
                         return Ok(Some(Invocation::AcceptedProposal));
                     } else {
-                        return Ok(Some(Invocation::NewProposal));
+                        // Opening an issue with a label assigned triggers both
+                        // "Opened" and "labeled" events.
+                        if e.action == github::IssuesAction::Opened
+                            || e.action == github::IssuesAction::Reopened
+                        {
+                            return Ok(Some(Invocation::NewProposal));
+                        } else {
+                            // Nothing to do, issue was labeled, but not marked
+                            // as accepted
+                            return Ok(None);
+                        }
                     }
                 }
             }