Skip to content

Commit

Permalink
Merge pull request #482 from rust-lang/revert-481-deliberate-ub
Browse files Browse the repository at this point in the history
Revert "deliberate-ub: mention the load-load races in tokio"
  • Loading branch information
RalfJung committed Dec 11, 2023
2 parents ea9f83b + de35af9 commit a4a6e5f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions resources/deliberate-ub.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@ We should evaluate whether there truly is some use-case here that is not current
see the [discussion here](https://github.com/rust-lang/unsafe-code-guidelines/issues/449).<br>
The alternative is to not use the "fast path" for problematic types (and fall back to the SeqLock), but that requires some way to query at `const`-time whether the type contains padding (or provenance).
(Or of course one can use inline assembly, but it would be better if that was not required.)
* tokio causes race conditions between atomic and non-atomic loads which are [not permitted](https://doc.rust-lang.org/nightly/std/sync/atomic/index.html#memory-model-for-atomic-accesses);
see [this issue](https://github.com/tokio-rs/tokio/issues/6155) for details.

### Cases related to aliasing

Expand Down

0 comments on commit a4a6e5f

Please sign in to comment.