Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glossary: define place, value, representation #180

Merged
merged 3 commits into from Aug 1, 2019

Conversation

@RalfJung
Copy link
Member

RalfJung commented Jul 25, 2019

As suggested during the meeting, moving this from #175 into its own PR.

I think I resolved the feedback I got, except for what I will now add again as comments here.

Cc @gnzlbg @Lokathor @rkruppe @Centril

@RalfJung RalfJung force-pushed the RalfJung:value-place-repr branch from fcafd6c to 3f3a8ab Jul 25, 2019
@gnzlbg
gnzlbg approved these changes Jul 25, 2019
Copy link
Collaborator

gnzlbg left a comment

LGTM.

@Lokathor

This comment has been minimized.

Copy link
Contributor

Lokathor commented Jul 25, 2019

Looks good. I'm going to unsubscribe from this but feel free to ping me once this glossary entry is added and I'll do that other PR where all the entries are put in alphabetical order and wrapped to 80 columns.

@RalfJung RalfJung mentioned this pull request Jul 26, 2019
@RalfJung RalfJung force-pushed the RalfJung:value-place-repr branch from 86f3ed5 to 78cad03 Jul 26, 2019
@RalfJung

This comment has been minimized.

Copy link
Member Author

RalfJung commented Jul 27, 2019

@ubsan I think you also have opinions on this.

@RalfJung RalfJung force-pushed the RalfJung:value-place-repr branch from dfbabc7 to f0511a2 Jul 28, 2019
@RalfJung RalfJung merged commit f3781c2 into rust-lang:master Aug 1, 2019
1 check passed
1 check passed
Travis CI - Pull Request Build Passed
Details
@RalfJung RalfJung deleted the RalfJung:value-place-repr branch Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.