Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all linter errors #49

Closed
julienfitz opened this issue Jul 5, 2018 · 4 comments
Closed

Fix all linter errors #49

julienfitz opened this issue Jul 5, 2018 · 4 comments
Labels
good first issue Good for newcomers

Comments

@julienfitz
Copy link
Contributor

julienfitz commented Jul 5, 2018 •
edited

If you run the linter right now, you'll see a bunch of linter errors. Some of these things are actual errors that need to be fixed, and some are just rules that need to be ignored (mainly the at-rule-no-unknown rule needs to have some ignoreAtRules added for SASSy things like mixin and import).

It may be helpful to look at the Stylelint documentation.

Fix all the things!

Related: #47
@julienfitz julienfitz added good first issue Good for newcomers dev labels Jul 5, 2018
@sendilkumarn
Copy link
Contributor

I can give this a shot 😄

@julienfitz
Copy link
Contributor Author

Awesome! Thanks so much @sendilkumarn 🙂

@sendilkumarn
Copy link
Contributor

I am not sure whether I can fork this repo. I will push changes to #47

@julienfitz
Copy link
Contributor Author

Fixed with #47 so closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julienfitz @sendilkumarn