Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate away from cargo_fetch and bind to cargo directly #167

Closed
xFrednet opened this issue Jul 10, 2023 · 0 comments · Fixed by #168
Closed

Migrate away from cargo_fetch and bind to cargo directly #167

xFrednet opened this issue Jul 10, 2023 · 0 comments · Fixed by #168
Assignees
@xFrednet
Labels
A-marker-cargo Area: All things connected to `cargo_marker`
Milestone
v0.1.0

Comments

@xFrednet
Copy link
Member

cargo-marker currently uses cargo_fetch as a wrapper around cargo. The dependency was added in #126 to support fetching crates from git and later from crates.io.

Sadly, cargo_fetch seems to be currently unmaintained: Niki4tap/cargo_fetch#1

I think the best approach would be to remove that dependency and bind to cargo directly. That binding will require some maintenance with every release, but that's just a part of Marker, similar to updating the toolchain every release.

Hopefully, at some point we'll get: rust-lang/cargo#1861
@xFrednet xFrednet added the A-marker-cargo Area: All things connected to `cargo_marker` label Jul 10, 2023
@xFrednet xFrednet added this to the v0.1.0 milestone Jul 10, 2023
@xFrednet xFrednet self-assigned this Jul 10, 2023
@xFrednet xFrednet changed the title Migrate away from cargo_fetch Migrate away from cargo_fetch and bind to cargo directly Jul 10, 2023
@xFrednet xFrednet mentioned this issue Jul 11, 2023
Merged
@bors bors bot closed this as completed in bc5848e Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xFrednet xFrednet

Labels
A-marker-cargo Area: All things connected to `cargo_marker`
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Cargo: Remove cargo_fetch dependency and rework the architecture xFrednet/marker
1 participant
@xFrednet