Cargo: Remove cargo_fetch dependency and rework the architecture
#168
Conversation
xFrednet
added
C-enhancement
|
Btw, let's make sure it works on every system bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
xFrednet
force-pushed
the
167-cargo-fetch-crates-something-something
branch
from
e719e11
to
ed7783b
Compare
|
bors try |
tryBuild failed: |
xFrednet
force-pushed
the
167-cargo-fetch-crates-something-something
branch
from
ed7783b
to
73a2f8b
Compare
|
Windows... bors try |
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
I noticed that the |
|
And once again bors try |
xFrednet
removed
the
A-tests
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
xFrednet
force-pushed
the
167-cargo-fetch-crates-something-something
branch
from
fd601ad
to
58a53b2
Compare
|
This was a fight... and still is... but for now: bors try |
I still like the idea of using `cargo-marker` as a library. However, this would limit the normal driver discovery mechanism for external uitests. This is not to say it can't be done, just that this is a good fix in the meantime.
tryBuild succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
I think now it works... Damn that was a fight... |
xFrednet
force-pushed
the
167-cargo-fetch-crates-something-something
branch
from
58a53b2
to
d58e9d0
Compare
Toolchains are pain, it would be so awesome if marker could just be a part of rustup
xFrednet
force-pushed
the
167-cargo-fetch-crates-something-something
branch
from
d58e9d0
to
af6d518
Compare
|
I'm sure this is still broken somehow, but everything seems to be working. So let's follow the: "What's the worst that can happen ¯\_(ツ)_/¯" philosophy and merge this. I have another branch, which requires the changes from this one and we can always update the code later :) bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
This PR exploded a bit 😅. Removing the dependency required a few more changes than expected. The good news are, that marker now uses a stable way to fetch lint crates which also supports registries directly. No more
cargodependency, just command calls. I'm happy :DIt also addresses or at least touches several other issues. Generally speaking, a nice update IMO. (The only big negative thing is the error handling. I've never learned how to do that properly, and cargo is getting more messy with less information after each refactoring 😅. I'll create an issue for that :))
Closes: #167
Closes: #155
Closes: #87
CC: #60