Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let marker handle normal crates and cleanup some conversion code in rustc #56

Closed
5 tasks done
xFrednet opened this issue Nov 18, 2022 · 1 comment · Fixed by #58
Closed
5 tasks done

Let marker handle normal crates and cleanup some conversion code in rustc #56

xFrednet opened this issue Nov 18, 2022 · 1 comment · Fixed by #58
Assignees
@xFrednet
Labels
A-driver Area: Driver or something related to the internal working of a driver. C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver
Milestone
v0.1.0

Comments

@xFrednet
Copy link
Member

xFrednet commented Nov 18, 2022 •
edited

This is a collection issue of several smaller cleanup tasks that should be handled. The main goal is to have cargo linter run without any panics. Currently, it runs into a few todo!()s in the type conversion.

TODOs

  • Fix triggered todo!()s when running cargo linter
  • remove cx argument from ID translation functions where it's not needed
  • (Optionally) Use generics for functions which are currently really wordy like to_api_item_id_from_def_id
  • Add item(ItemId) fetch function to AstContext and use that in the adapter. This might be good to handle in another issue.
  • Store generic parameter bounds in parameters or update the documentation
@xFrednet xFrednet added C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver A-driver Area: Driver or something related to the internal working of a driver. labels Nov 18, 2022
@xFrednet xFrednet self-assigned this Nov 18, 2022
@xFrednet xFrednet added this to the v0.0.1 milestone Nov 18, 2022
@xFrednet xFrednet mentioned this issue Nov 19, 2022
Merged
@xFrednet
Copy link
Member Author

I'm working on this issue in 056-another-cleanup-branch I'll check of the completed items even if they're only on my dev branch

bors bot added a commit that referenced this issue Nov 23, 2022
@bors @xFrednet
Merge #57
dc6e411 
57: Add item conversion backend for rustc r=xFrednet a=xFrednet

This is still a rough diamond. I want to do some more cleanup, but prefer to do that in a follow-up PR, as this has again grown into a monster with ~1000 line changes. #56 lists some remaining TODOs. Some of these are also less related to items and more to the type system.

Closes #53 
Progress on #35




Co-authored-by: xFrednet <xFrednet@gmail.com>
@xFrednet xFrednet mentioned this issue Nov 23, 2022
Merged
@bors bors bot closed this as completed in f399207 Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xFrednet xFrednet

Labels
A-driver Area: Driver or something related to the internal working of a driver. C-enhancement Category: New feature or request D-rustc-driver Driver: Rustc Driver
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

Add more syntactic types, update rustc impl and general clean up xFrednet/marker
1 participant
@xFrednet