A good chunk of stable patterns for marker #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rustc representation is quite genius and will make linting simpler for everyone
xFrednet
added
A-api
8 tasks
Niki4tap
reviewed
Jan 4, 2023
|
Nice catches, I'll update the PR later this week. Thank you for the review! |
|
bors delegate=Niki4tap |
|
✌️ Niki4tap can now approve this pull request. To approve and merge a pull request, simply reply with |
|
Would you mind reviewing this again? Otherwise, I can also merge it at the next step as usual :) |
Niki4tap
reviewed
Jan 6, 2023
Co-authored-by: Niki4tap <rombiklol2@gmail.com>
xFrednet
force-pushed
the
050-let-pattern-s
branch
from
919e51c
to
16b6af8
Compare
|
Looks good! bors r+ |
|
I think the bors comment has to be on its own line right at the start, edits are a bit weird at times xD Uhh magic xD. Thank you for the review <3 |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's interesting to see how important patterns are to Rust. We use them all the time, often without noticing them. This adds the first few patterns, that can be expressed without expressions. Most of these can't be tested, but I'll try to add the rustc backend for them next.
CC: #50
As per usual, I'll merge this, if there has been no outside interaction, by the time I have the next PR ready. And reviews and feedback is very welcome!