Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove windows-sys dependency #58

Closed
Jake-Shadle opened this issue Oct 21, 2022 · 1 comment · Fixed by #60
Closed

Remove windows-sys dependency #58

Jake-Shadle opened this issue Oct 21, 2022 · 1 comment · Fixed by #60
Labels
enhancement New feature or request

Comments

@Jake-Shadle
Copy link
Collaborator

windows-sys is still moving far too quickly resulting in churn and duplicate dependencies, the usage in this crate is quite limited, so it makes sense to just bite the bullet and handwrite the binding we actually need and remove the dependency so that downstream crates don't have to care which version of windows-sys they may use.
@Jake-Shadle Jake-Shadle added the enhancement New feature or request label Oct 21, 2022
@Jake-Shadle Jake-Shadle mentioned this issue Oct 21, 2022
Closed
@gabrielesvelto
Copy link
Contributor

You might want to cherry-pick mozilla@951d2d8

gabrielesvelto added a commit to gabrielesvelto/minidump-writer that referenced this issue Oct 24, 2022
@gabrielesvelto
Use the winapi crate instead of the windows-sys one for the Windows b…
a0a4d0e 
…indings

This fixes rust-minidump#58
@gabrielesvelto gabrielesvelto mentioned this issue Oct 24, 2022
Closed
@Jake-Shadle Jake-Shadle mentioned this issue Oct 26, 2022
Merged
@Jake-Shadle Jake-Shadle mentioned this issue Nov 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@gabrielesvelto @Jake-Shadle