Make dir_section and mem_writer modules public
#53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`./examples/synthetic.rs` demonstrates how consumers may use those modules, regardless of `target_os`, to construct and serialize a minidump.
|
This is fine by me, @Jake-Shadle @Gankra have you any opinions on this? |
Jake-Shadle
approved these changes
Aug 24, 2022
There was a problem hiding this comment.
I guess this is fine for now, but might make more sense to pull out the helpers around writing the minidump to the minidump crate at some point since it feels a bit weird to compile a bunch of code meant for inspecting external process state without using any of it.
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to construct minidumps from other data sources, so having access to types provided by these modules would be helpful.
Based on the current public API it seems the primary use case of
minidump-writeris to construct a minidump by introspecting on the current execution environment.Could you support this use case, either by adopting this change or working with me to find another solution?