Add additional bounds to Float trait #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will look into the issue with argmin first, before mergin this |
|
can confirm that this is a regression introduced by the latest nightly compiler version, can you pin the toolchain to |
|
you need to do the same for |
|
sorry I'm a bit busy right now working through my backlog 😅 |
Sauro98
added a commit
to Sauro98/linfa
that referenced
this pull request
Apr 9, 2021
* Add additional bounds to Float trait (rust-ml#118) * Add bounds to Float trait, allowing trait bounds in dependant crates to be simplified * Pin nightly toolchain * Retry pinning toolchain * Fix CI * Move nightly version back to 2021-3-24 * Fix tarpaulin nightly invocation * Implement Transform for K-means (rust-ml#117) Co-authored-by: Yuhan Lin <yuhanliin+github@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding these bounds allow trait bounds on
Floatin dependent crates to be simplified. These simplifications were made inlinfa-clustering.