Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing serde derives on KMeansInit #128

Merged
merged 3 commits into from
May 14, 2021
Merged

fix missing serde derives on KMeansInit #128

merged 3 commits into from
May 14, 2021

Conversation

pYtoner
Copy link
Contributor

@pYtoner pYtoner commented May 8, 2021

I changed my linfa_clustering version from 0.3 to 0.4 and I was unable to use serde with linfa_clustering::KMeans. I looked at the errors and KMeansInit didn't have any serde derives / implementations.

@bytesnake
Copy link
Member

can you run rustfmt, then I will merge

@codecov-commenter
Copy link

codecov-commenter commented May 9, 2021

Codecov Report

Merging #128 (fe14809) into master (48c9bd7) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
- Coverage   59.93%   59.87%   -0.06%     
==========================================
  Files          74       74              
  Lines        7006     7006              
==========================================
- Hits         4199     4195       -4     
- Misses       2807     2811       +4     
Impacted Files Coverage Δ
algorithms/linfa-clustering/src/k_means/init.rs 87.23% <ø> (ø)
...rithms/linfa-trees/src/decision_trees/algorithm.rs 51.08% <0.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48c9bd7...fe14809. Read the comment docs.

@pYtoner
Copy link
Contributor Author

pYtoner commented May 9, 2021

Done. Sorry forgot to run fmt because it was such a small change 😃

@bytesnake
Copy link
Member

Done. Sorry forgot to run fmt because it was such a small change smiley

no worries, for that we have the CI 😄

@bytesnake bytesnake merged commit d6b7892 into rust-ml:master May 14, 2021
@YuhanLiin YuhanLiin mentioned this pull request May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants