Remove blas from linfa clustering #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should blas testing also be removed from CI for linfa-clustering? |
Codecov ReportBase: 39.17% // Head: 39.24% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #257 +/- ##
==========================================
+ Coverage 39.17% 39.24% +0.07%
==========================================
Files 92 92
Lines 6096 6092 -4
==========================================
+ Hits 2388 2391 +3
+ Misses 3708 3701 -7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
You need to update the README as well. Also remove |
|
done @YuhanLiin |
YuhanLiin
reviewed
Nov 1, 2022
| @@ -24,8 +24,7 @@ Implementation choices, algorithmic details and a tutorial can be found | |||
| **WARNING:** Currently the Approximated DBSCAN implementation is slower than the normal DBSCAN implementation. Therefore DBSCAN should always be used over Approximated DBSCAN. | |||
|
|
|||
| ## BLAS/Lapack backend | |||
|
|
|||
| See [this section](../../README.md#blaslapack-backend) to enable an external BLAS/LAPACK backend. | |||
| We found that the pure Rust implementation maintained similar performance to the BLAS/LAPACK version. Thus, to reduce code complexity BLAS support has been removed for this module. | |||
There was a problem hiding this comment.
Mention this PR here as well
YuhanLiin
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to remove blas support from linfa-clustering per #255