Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test DecisionTree fit method #39

Closed
wants to merge 1 commit into from

Conversation

fgadaleta
Copy link
Contributor

DecisionTree fit doesn't seem to return the same result from a known Python equivalent (sklearn code below)

clf = tree.DecisionTreeClassifier()                                                                                                        
X = [ [1,2,3], [1, 2, 3.5], [1.2, 3, 4]  ]                                                                                                 
clf = clf.fit(X, [0,0,1])                                                                                                                  
clf.predict(X)                                                                                                                             
  array([0, 0, 1])

In this case, predicted labels should equal the ground truth. In the Rust implementation I cannot print that.

@paulkoerbitz
Copy link
Collaborator

Thanks for contributing this. Indeed concerning. Would you be willing to investigate why this problem occurs?

@bytesnake bytesnake closed this Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants