Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call Activity.finish() when android_main returns #81

Merged
merged 1 commit into from
Jun 19, 2023
Merged

Call Activity.finish() when android_main returns #81

merged 1 commit into from
Jun 19, 2023

Conversation

rib
Copy link
Collaborator

@rib rib commented Apr 27, 2023

Calling Activity.finish() is what ensures the Activity will get gracefully destroyed, including calling the Activity's onDestroy method.

Fixes: #67

@rib rib requested review from MarijnS95 April 27, 2023 21:19
MarijnS95
MarijnS95 approved these changes May 1, 2023
View reviewed changes
Copy link
Member

@MarijnS95 MarijnS95 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, especially a good idea to also invoke all this cleanup when android_main() returns via panicking/unwinding :). That's strictly a separate change though.

android-activity/src/native_activity/glue.rs Show resolved Hide resolved
@rib
Call Activity.finish() when android_main returns
3843a7c 
Calling Activity.finish() is what ensures the Activity will get
gracefully destroyed, including calling the Activity's onDestroy
method.

Fixes: rust-mobile#67
@rib rib merged commit 79e03e0 into rust-mobile:main Jun 19, 2023
3 checks passed
@rib rib mentioned this pull request Jun 22, 2023
Merged
@MarijnS95 MarijnS95 mentioned this pull request Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 Awaiting requested review from MarijnS95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Call ANativeActivity_finish() or GameActivity_finish() when android_main returns
2 participants
@rib @MarijnS95