-
Notifications
You must be signed in to change notification settings - Fork 109
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
CI: Only require MSRV-check to succeed with
-Zminimal-versions
(#443)
* CI: Only require MSRV-check to succeed with `-Zminimal-versions` One of our dependencies recently bumped its `rust-version` causing our MSRV test to _break again_. It is undesired to randomly work around this by bumping our MSRV, or consistently have PRs/merges fail for unrelated reasons. Instead, perform the MSRV-test with `-Zminimal-versions`. This seems to be generally accepted in the Rust ecosystem (as there is otherwise no way for crates to bump MSRV barring a semver-breaking release) and prevents us from hitting unnecessary MSRV build failures caused by dependencies. At the same time our minimal version bounds are now exercised, ensuring downstream crates depending on the `ndk` can build with `-Zminimal-versions` too - which required specifying a few patch bounds for our dependencies. Unfortunately GitHub's UI for `continue-on-error: true` doesn't make it obvious that a step/job really didn't succeed, this is only visible from the annotations. Still, it is relevant to keep track of whether our non-`minimal-versions` build adheres to MSRV. * Bump `actions/checkout` to `v4` Getting a bunch of deprecation warnings on the _ancient_ (almost 4 years old) `v1` release.
- Loading branch information
Showing
3 changed files
with
26 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters