Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-apk: Print and follow adb logcat output after starting app #332

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

Jasper-Bekkers
Copy link
Contributor

Depends on #331

This starts a logcat session for our PID so we have something that's a bit more akin to how cargo run regularly works. If this is undesired, I would also be OK with adding a --log argument.

@Jasper-Bekkers
Copy link
Contributor Author

@MarijnS95 I suspect the CI script to potentially require an update after this, but I'm not entirely sure. Looks like it got stuck as well after about ~5 hours.

Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to have this by default, I added a --no-logcat option to back out of this, for example in the CI.

(We could/should also use the cargo apk run logcat output in CI to test if the right strings are printed, but there's currently no neat way to pass the -d option to logcat so that it exits pretty soon. At the same time that doesn't guarantee the app has properly reached the print statement, but the CI has always been running on good faith given that -W was never passed to am start either yet the app always started in time.)

@MarijnS95 MarijnS95 changed the title Logcat output for PID cargo-apk: Print and follow adb logcat output after starting app Sep 8, 2022
@MarijnS95 MarijnS95 merged commit 8a161c0 into rust-mobile:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants