Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ndk-sys: Regenerate against NDK 25.2.9519653 with rust-bindgen 0.66.0 #370

Merged
merged 1 commit into from
Jun 15, 2023
Merged

ndk-sys: Regenerate against NDK 25.2.9519653 with rust-bindgen 0.66.0 #370

merged 1 commit into from
Jun 15, 2023

Conversation

MarijnS95
Copy link
Member

@MarijnS95 MarijnS95 commented Nov 23, 2022 •
edited

Regenerate ndk-sys against the latest NDK toolchain with the latest rust-bindgen release, noting that this rust-bindgen bump has some breaking type changes that trickle down into downstream ndk and ndk-glue crates too.

MarijnS95
MarijnS95 commented Nov 23, 2022
View reviewed changes
ndk-sys/CHANGELOG.md Outdated Show resolved Hide resolved
@MarijnS95
Copy link
Member Author

Guess the CI just answered my question: our ndk crate heavily relied on the pub type size_t = ::std::os::raw::c_ulong; alias (that has now been replaced with usize) via referencing ffi::size_t everywhere :)

@MarijnS95
Copy link
Member Author

MarijnS95 commented Nov 23, 2022 •
edited

Okay, I've set everything up towards a release, but I don't think that I'll actually release this today nor (any time) soon unless someone is actively in need of an ndk-sys regen bump, in which case we should see towards bumping and releasing ndk breaking changes as well. I'll just leave this PR open to take these changes into account whenever we're ready to perform the next breaking release (and allow doing nonbreaking smaller releases in the meantime), in hopes of picking up some more changes first.

Alternatively we can bump down bindgen too, if there's a need for NDK 25 bindings.

MarijnS95
MarijnS95 commented Feb 15, 2023
View reviewed changes
ndk/CHANGELOG.md Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 changed the title ndk-sys: Regenerate against 25.1.8937393 and release ndk-sys-0.4.2 ndk-sys: Regenerate against 25.2.9519653 and release ndk-sys-0.5.0 Mar 29, 2023
@MarijnS95 MarijnS95 mentioned this pull request Jun 15, 2023
Merged
@MarijnS95 MarijnS95 changed the title ndk-sys: Regenerate against 25.2.9519653 and release ndk-sys-0.5.0 ndk-sys: Regenerate against NDK 25.2.9519653 with rust-bindgen 0.66.0 Jun 15, 2023
@MarijnS95 MarijnS95 added type: maintenance Repaying technical debt impact: breaking API/ABI-breaking change labels Jun 15, 2023
@MarijnS95 MarijnS95 force-pushed the ndk-sys-0.4.2 branch 4 times, most recently from ac52f17 to 7d674bc Compare June 15, 2023 12:08
@MarijnS95
ndk-sys: Regenerate against NDK 25.2.9519653 with rust-bindgen 0.66.0
de1499e 
Regenerate `ndk-sys` against the latest NDK toolchain with the latest
`rust-bindgen` release, noting that this `rust-bindgen` bump has some
breaking type changes that trickle down into downstream `ndk` and
`ndk-glue` crates too.
@MarijnS95 MarijnS95 merged commit 1ca2b26 into master Jun 15, 2023
36 checks passed
@MarijnS95 MarijnS95 deleted the ndk-sys-0.4.2 branch June 15, 2023 12:45
@paxbun paxbun mentioned this pull request Jun 16, 2023
Open
@MarijnS95 MarijnS95 mentioned this pull request Jun 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
impact: breaking API/ABI-breaking change type: maintenance Repaying technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@MarijnS95