ndk/native_window: Link against libnativewindow for API >= 26 functions
#465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions Per [the `libandroid` function map][1] newer `NativeWindow` functions are no longer available; these instead need to be linked [from the `libnativewindow` library][2] directly. [1]: https://cs.android.com/android/platform/superproject/main/+/main:frameworks/base/native/android/libandroid.map.txt;l=1?q=libandroid.map.txt&sq=&ss=android%2Fplatform%2Fsuperproject%2Fmain [2]: https://cs.android.com/android/platform/superproject/main/+/main:frameworks/native/libs/nativewindow/libnativewindow.map.txt;l=1?q=libnativewindow.map.txt&sq=&ss=android%2Fplatform%2Fsuperproject%2Fmain
MarijnS95
force-pushed
the
native-window-libandroid
branch
from
1769ca2
to
e3757b0
Compare
rib
approved these changes
Feb 2, 2024
MarijnS95
commented
Feb 4, 2024
| @@ -377,7 +378,7 @@ impl<'a> Drop for NativeWindowBufferLockGuard<'a> { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(feature = "api-level-26")] | |||
| #[cfg(all(feature = "nativewindow", feature = "api-level-26"))] | |||
There was a problem hiding this comment.
I'm just realizing that I'll revert this and the change for the two enums below for SurfaceTransaction again (in an upcoming PR), as these are exposed directly from libandroid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the
libandroidfunction map newerNativeWindowfunctions are no longer available; these instead need to be linked from thelibnativewindowlibrary directly.Ref: android/ndk#1982