ndk-sys: Generate against latest upstream NDK (11769913)
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://github.com/rust-mobile/ndk/actions/runs/8530126195/job/23367341518?pr=471 one of the CI runs is showing very nicely that upstream reports and changes are trickling down into this sysroot. The type of |
We're seeing with the R26 NDK release, which was published only half a month before the Android 14 (U, API level 34) release, that a lot of new APIs are still missing. This is not something we can deal with for very long in the NDK Rust crate, as we'd like to try out and use the latest functions at some point. These are not showing up in the followup r26b and r26c releases, nor does the r27 release seem close. Fortunately live NDK builds of the `aosp-main` branch were pointed out which seem to include mostly if not exclusively stable changes to NDK (related) headers. As we're generally analyzing the changes and propagating them to the NDK wrappers (mostly additions, because API breaks are disallowed) we'd quickly catch a faulty push. For now the only break is in a previously-faulty enum-constant name in `ADataSpace`. Furthermore the upstream NDK finally contains some fixes that have been submitted to C++-like headers to make them once again C-compatible, and will allow us to start submitting bindings for: - `ASurfaceControl` - `ASurfaceTexture` - `Parcel` - `AIBinder` - And more. New functions and enum variants enabled by this `ndk-sys` upgrade will be submitted in separate PRs too.
MarijnS95
changed the title
11661618)11769913)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeing with the R26 NDK release, which was published only half a month before the Android 14 (U, API level 34) release, that a lot of new APIs are still missing. This is not something we can deal with for very long in the NDK Rust crate, as we'd like to try out and use the latest functions at some point. These are not showing up in the followup r26b and r26c releases, nor does the r27 release seem close.
Fortunately live NDK builds of the
aosp-mainbranch were pointed out which seem to include mostly if not exclusively stable changes to NDK (related) headers. As we're generally analyzing the changes and propagating them to the NDK wrappers (mostly additions, because API breaks are disallowed) we'd quickly catch a faulty push.For now the only break is in a previously-faulty enum-constant name in
ADataSpace.Furthermore the upstream NDK finally contains some fixes that have been submitted to C++-like headers to make them once again C-compatible, and will allow us to start submitting bindings for:
ASurfaceControlASurfaceTextureParcelAIBinderNew functions and enum variants enabled by this
ndk-sysupgrade will be submitted in separate PRs too.