Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Whitelist only libui declarations in bindings #104

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Whitelist only libui declarations in bindings #104

wants to merge 1 commit into from

Conversation

LoganDark
Copy link

@LoganDark LoganDark commented Aug 25, 2020

Cuts down on stuff like this, on every platform:

image

Reduces the size of the generated bindings on my platform from 3476 lines to 2775, while iui is still fully functional. Granted, I'm comparing this PR to my own modified version (notice how I have like 5 pull requests open right now?), but that is a huge difference.

@LoganDark
Copy link
Author

The [A-Z] is to prevent it from whitelisting every uint type as well. Lemme know if you want a comment explaining that

@NoraCodes
Copy link
Collaborator

Yeah, neat stuff. Thank you!

@NoraCodes NoraCodes added c-enhancement New feature or request k-dependencies Issues with the crate's dependencies p-medium Medium Priority labels Aug 29, 2020
@NoraCodes NoraCodes added this to the 0.5 Release milestone Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-enhancement New feature or request k-dependencies Issues with the crate's dependencies p-medium Medium Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants