Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite LAPACKE by Rust, call LAPACK directly #206

Merged
merged 61 commits into from
Jul 26, 2020
Merged

Rewrite LAPACKE by Rust, call LAPACK directly #206

merged 61 commits into from
Jul 26, 2020

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Jun 29, 2020

Resolve #111, meta development branch

Goal

Drop lapacke dependency

Changes

  • The order of eigenvalue for general matrices changes
  • Implement C/F-continuous array handling
  • Create temporal work vector in Rust (replacement of LAPACKE_malloc)
  • Drop unsafe from lax traits

TODO

@termoshtt termoshtt force-pushed the lapack branch 2 times, most recently from 41bc38d to bde41ed Compare July 4, 2020 14:30
@termoshtt termoshtt mentioned this pull request Jul 11, 2020
@termoshtt termoshtt marked this pull request as ready for review July 26, 2020 09:27
@termoshtt
Copy link
Member Author

termoshtt commented Jul 26, 2020

https://github.com/rust-ndarray/ndarray-linalg/runs/911395642

failures:

---- least_squares_f32_exact_af_bf stdout ----
[ndarray-linalg\tests\least_squares_nrhs.rs:12] &result = LeastSquaresResult {
    singular_values: [1.2196491, 0.4119807, 0.0000654747], shape=[3], strides=[1], layout=CF (0x3), const ndim=1,
    solution: [[-919.2319, 6852.095],
     [235.25002, -1752.6882],
     [-25.910263, 201.41443]], shape=[3, 2], strides=[1, 3], layout=F (0x2), const ndim=2,
    rank: 3,
    residual_sum_of_squares: Some(
        [0.0, 0.0], shape=[2], strides=[1], layout=CF (0x3), const ndim=1,
    ),
}
==== Assetion Failed ====
Expected:
[[0.5019542, 0.5917609],
 [0.7649941, 0.07200937],
 [0.0060762856, 0.9174205]]
Actual:
[[0.5019411, 0.59185815],
 [0.7650014, 0.07195431],
 [0.0059943795, 0.91799533]]
thread 'least_squares_f32_exact_af_bf' panicked at 'Too large deviation in L2-norm: 0.00041470854 > 0.0001 ', /rustc/c7087fe00d2ba919df1d813c040a5d47e43b0fe7\src\libstd\macros.rs:16:9

@termoshtt termoshtt merged commit 34f7b99 into master Jul 26, 2020
@termoshtt termoshtt deleted the lapack branch July 26, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use LAPACK instead of LAPACKE
1 participant