Reimplement IxDyn, with no allocation for the small dimension case #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, beta ICE we see is fixed upstream <3 rust-lang/rust/pull/40813 |
6 tasks
This means that low-dimensional IxDyn are stored inline and don't need an allocation for creation and cloning.
(Enables indexing a zero dimensional dynamic dimension array using array[[]], array[()], array[Ix0()])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Box<[T]>.Dim<Vec<Ix>>as a dimension is replaced byDim<IxDynImpl>. Vec and slices still implementIntoDimension → IxDynthe same way, though.IxDynacross the board, maybe not as much as you would think. (For example: Binary operations on arrays don't care about dimension type if both operands are contiguous, so then we can't improve that.)Fixes #285