Add table of conversions to/from Vecs and slices #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jturner314
force-pushed
the
doc-more-conversions
branch
2 times, most recently
from
9ea39a8
to
b8798ef
Compare
bluss
reviewed
Nov 4, 2018
| @@ -851,6 +851,25 @@ pub type Ixs = isize; | |||
| /// </tr> | |||
| /// </table> | |||
| /// | |||
There was a problem hiding this comment.
Can we put a heading here, so that it's possible to find this?
I also want to disclaim the as_slice methods with the information that it is of course a conversion that not every array supports. (Arrays are not necessarily contiguous or in order.) I think that this information needs to be stated again, since it is non-obvious to the users that start out.
There was a problem hiding this comment.
I've added headings, and I've added footnotes for the restrictions on .as_slice*().
|
I added comments but it doesn't need to be perfect to be merged, this is docs. Nice to have! 🙂 |
jturner314
force-pushed
the
doc-more-conversions
branch
from
b8798ef
to
264a0ce
Compare
jturner314
force-pushed
the
doc-more-conversions
branch
from
264a0ce
to
fa78de1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves discoverability. See also #524 for motivation.