Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs of .raw_dim(), .shape(), and .strides() #591

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

jturner314
Copy link
Member

This should help prevent a common source of confusion, even among relatively experienced ndarray users: using .shape() where .raw_dim() is necessary. This has come up multiple times in the past.

Please let me know if the wording could be improved.

@LukeMathWalker
Copy link
Member

Yes please ❤️

@bluss
Copy link
Member

bluss commented Mar 6, 2019

@jturner314 @LukeMathWalker Is it possible you want to join maintenance team @LukeMathWalker? I'm away more than not, so I'm really not helping unfortunately. If you drive development you can also make decisions independently from me. (That's how it should be if I don't show up.)

@LukeMathWalker
Copy link
Member

I'd be more than happy to join the maintenance team @bluss: I have learned most of the non-trivial things I know about Rust using/messing up/trying to expand ndarray and putting that code out for review by you and @jturner314 - it would be exciting to get more involved with the project, giving something back.
I can't say I am familiar with the deepest and darkest corners of ndarray, but the goal is getting there 😛

@jturner314
Copy link
Member Author

@bluss @LukeMathWalker I've added @LukeMathWalker as a GitHub team member and collaborator. Welcome to the team! You've been doing great work on ndarray-stats and ndarray, and I'm glad to have you with us!

@jturner314 jturner314 merged commit 19a09ca into rust-ndarray:master Mar 25, 2019
@jturner314 jturner314 deleted the improve-shape-docs branch March 25, 2019 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants