Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customize route failure response #10

Closed
aturon opened this issue Nov 8, 2018 · 2 comments
Closed

Customize route failure response #10

aturon opened this issue Nov 8, 2018 · 2 comments
Labels
feature A feature that's ready for implementation good first issue Good for newcomers
Milestone

Comments

@aturon
Copy link
Collaborator

aturon commented Nov 8, 2018

Right now, Tide always returns an empty 404 response when there is no route match. This should be customizable.

Possibly blocked by #5, if we want to use the same configuration mechanism for this.

@aturon aturon added good first issue Good for newcomers feature A feature that's ready for implementation labels Nov 8, 2018
@aturon
Copy link
Collaborator Author

aturon commented Nov 19, 2018

Also note that currently no middleware is applied to this fallback 404 responder. Worth thinking if that's what we want.

@tzilist
Copy link
Contributor

tzilist commented Nov 19, 2018

@aturon Currently working on this. Thought process is as follows:

We can allow user's to specify a default handler. This function will run if no route match is found. The other thing i'd like to implement is an error handler akin to actix-web's, see here. I think between the two of them, that should give a pretty good start for handling any kind of failures that can happen during a request :) Let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A feature that's ready for implementation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants