Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement sqrt function #55

Closed
Pzixel opened this issue Jul 10, 2018 · 2 comments
Closed

Implement sqrt function #55

Pzixel opened this issue Jul 10, 2018 · 2 comments

Comments

@Pzixel
Copy link

Pzixel commented Jul 10, 2018

There is currently no SQRT function which is critically important to have. Multiple algorithms on arbitrary-precision types require it. I think it worth to implement it in the crate, and as a result - in depended types, such as Ratio.

@cuviper
Copy link
Member

cuviper commented Jul 10, 2018

It's coming here -- see #51.

Ratio will be trickier to deal with precision, because you probably don't want to just round √(a/b) by operating on the numerator and denominator separately. That is, ⌊√a⌋/⌊√b⌋ would be quite lossy.
(But we should take that discussion to the num-rational repo.)

@Pzixel
Copy link
Author

Pzixel commented Jul 10, 2018

Sorry, I've checked that there is not open discussion about it, but I didn't check open PRs. Shame on me 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants