Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies #110

Merged
merged 9 commits into from
Jan 14, 2020
Merged

Bump dependencies #110

merged 9 commits into from
Jan 14, 2020

Conversation

kpcyrd
Copy link
Contributor

@kpcyrd kpcyrd commented Sep 7, 2019

This bumps rand and quickcheck to the latest version. We're about to ship num-bigint with this patch applied.

@cuviper
Copy link
Member

cuviper commented Sep 9, 2019

The code looks correct. I've also been playing with this locally, and we might want to tweak what rand features are pulled in, especially where they're only for dev-deps, but this is a minor point.

However, this is breaking change, since these are public dependencies -- you're changing public trait implementations to semver-incompatible versions.

We're about to ship num-bigint with this patch applied.

Who is "we"? Are you shipping this as an internal detail, or is it something that will be publicly visible and different than the crates.io num-bigint?

@kpcyrd
Copy link
Contributor Author

kpcyrd commented Sep 10, 2019

oops, didn't pay enough attention when writing the text, "we" is referring to the debian rust team, the crate is used when building packages that depend on num-bigint. semver-incompatible reexports aren't much of a problem in that case.

@programmerjake
Copy link

see also #75

@cuviper cuviper mentioned this pull request Oct 21, 2019
@cuviper cuviper mentioned this pull request Jan 10, 2020
7 tasks
@cuviper
Copy link
Member

cuviper commented Jan 14, 2020

I took the liberty of rebasing this and stacking some more changes on top. The MSRV is now 1.31, and 128-bit integer support is assumed. MSRV with rand, quickcheck, and no_std are all higher, respectively 1.32, 1.34, and 1.36. We now support rand on no_std too, and I moved some of the rand and quickcheck tests to sub-crates to avoid "polluting" the main dependencies. I want to do a Rust 2018 conversion too, but I'll do that separately.

Thanks!

bors r+

bors bot added a commit that referenced this pull request Jan 14, 2020
110: Bump dependencies r=cuviper a=kpcyrd

This bumps rand and quickcheck to the latest version. We're about to ship num-bigint with this patch applied.

Co-authored-by: kpcyrd <git@rxv.cc>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 14, 2020

Build failed

@cuviper
Copy link
Member

cuviper commented Jan 14, 2020

Some 503 errors from crates.io -- let's try again.

bors retry

bors bot added a commit that referenced this pull request Jan 14, 2020
110: Bump dependencies r=cuviper a=kpcyrd

This bumps rand and quickcheck to the latest version. We're about to ship num-bigint with this patch applied.

Co-authored-by: kpcyrd <git@rxv.cc>
Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 14, 2020

Build succeeded

@bors bors bot merged commit e7cdb53 into rust-num:master Jan 14, 2020
@kpcyrd kpcyrd deleted the dependencies branch January 14, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants