Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to 2018 edition and clippy fixes #130

Merged
merged 25 commits into from
Jan 15, 2020
Merged

Update to 2018 edition and clippy fixes #130

merged 25 commits into from
Jan 15, 2020

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Jan 14, 2020

No description provided.

@cuviper
cargo fix --edition && cargo fmt
3a6fbae
@cuviper
Update to 2018 edition
8b9e9f3
@cuviper
cargo fix --edition-idioms && cargo fmt
28069b4
@cuviper
Remove the num_traits/integer aliases
cec2de0
@cuviper
Use pub(crate) for unreachable-pub
fdaf67c
@cuviper
use dyn Trait
1074899
@cuviper
use inclusive range patterns
9e33a28
@cuviper
clean up allowed lints
f3d7ffa
@cuviper
Fix clippy::redundant_field_names
1e0f71a
@cuviper
Refactor comparisons
c8fd853
@cuviper
Fix clippy::derive_hash_xor_eq
e9ca3e1
@cuviper
allow clippy::suspicious_arithmetic_impl for BigInt
274a4ae
@cuviper
allow clippy::float_cmp in exact conversion tests
7473be0
@cuviper
Fix clippy::redundant_static_lifetimes
4aed03b
@cuviper
Fix clippy::if_same_then_else
8931524
@cuviper
Fix clippy::write_with_newline
cecf70d
@cuviper
Fix clippy::range_plus_one
c12c4ac
@cuviper
Fix clippy::needless_return
90ff009
@cuviper
Fix clippy::assign_op_pattern
1da4abc
@cuviper
Fix clippy::comparison_chain
facc5dd
@cuviper
Fix clippy::string_lit_as_bytes
9c34007
@cuviper
Fix clippy::match_bool
5b4bc45
@cuviper
Fix clippy::match_wild_err_arm
512d3ee
@cuviper
Fix clippy::redundant_clone
7c48ca7
@cuviper
Use the ? operator with Option
25913e8
@cuviper cuviper mentioned this pull request Jan 14, 2020
Closed
7 tasks
@cuviper
Copy link
Member Author

cuviper commented Jan 14, 2020

bors r+

@cuviper
Copy link
Member Author

cuviper commented Jan 15, 2020

hello?

bors r+

bors bot added a commit that referenced this pull request Jan 15, 2020
@bors @cuviper
Merge #130
d182c71 
130: Update to 2018 edition and clippy fixes r=cuviper a=cuviper



Co-authored-by: Josh Stone <cuviper@gmail.com>
@bors
Copy link
Contributor

bors bot commented Jan 15, 2020

Build succeeded

@bors bors bot merged commit 25913e8 into rust-num:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@cuviper