Update to rand 0.5 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 23, 2018
48: Update to rand 0.5 r=cuviper a=cuviper This closes #47, choosing to *only* support rand 0.5 (and only for their supported rustc 1.22+). The `RandBigInt` trait still exists as an extension to all `Rng` types. It's no longer defined at all when the "rand" feature is not enabled. That was a misbehavior before, as enabling "rand" adds a blanket implementation, which would be a breaking change just by toggling the feature. `BigUint` and `BigInt` now implement `SampleUniform` too, which lets them work natively with `Rng::gen_range`, `Rng::sample`, and `Uniform` in general. Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #47, choosing to only support rand 0.5 (and only for their supported rustc 1.22+).
The
RandBigInttrait still exists as an extension to allRngtypes. It's no longer defined at all when the "rand" feature is not enabled. That was a misbehavior before, as enabling "rand" adds a blanket implementation, which would be a breaking change just by toggling the feature.BigUintandBigIntnow implementSampleUniformtoo, which lets them work natively withRng::gen_range,Rng::sample, andUniformin general.