Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cis function #101

Merged
merged 5 commits into from Apr 29, 2022
Merged

Add cis function #101

merged 5 commits into from Apr 29, 2022

Conversation

rayhem
Copy link

@rayhem rayhem commented Apr 25, 2022

Adds a cis function as a convenient way to construct a complex number with a specific phase/angle. Shorthand for (Complex::i() * angle).exp().

@cuviper cuviper changed the base branch from trying to master April 25, 2022 21:55
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@rayhem rayhem requested a review from cuviper April 27, 2022 16:18
src/lib.rs Outdated Show resolved Hide resolved
@rayhem rayhem requested a review from cuviper April 29, 2022 00:07
@cuviper
Copy link
Member

cuviper commented Apr 29, 2022

Looks good!

bors r+

@bors
Copy link
Contributor

bors bot commented Apr 29, 2022

@bors bors bot merged commit d0a06ca into rust-num:master Apr 29, 2022
@rayhem
Copy link
Author

rayhem commented Apr 30, 2022

Thank you for the review @cuviper and for making it easy to make my first Rust PR!

@cuviper
Copy link
Member

cuviper commented May 3, 2022

@rayhem I just noticed that GitHub identified your commits under a different name, @cglosser, which is what I collected into the release notes. Are these just alternate accounts of yours? Do you care which is in the release notes?

@rayhem
Copy link
Author

rayhem commented May 5, 2022

@cuviper Yeah, those are both me. I'm not exactly sure how that happened; I think it's something to do with the gh utility that's replaced direct ssh access. Anyway, @rayhem is slightly preferable, but it doesn't matter much either way (especially if it's a hassle to change).

cuviper added a commit that referenced this pull request May 5, 2022
@cuviper
Copy link
Member

cuviper commented May 5, 2022

I can't change the file in the published artifacts, but I've updated the release notes anyway.

I believe GitHub simply looks at the commit's author email to make that association. It will also indicate a separate committer if that's different, as seen in git log --pretty=fuller. I don't know how it decides if there are multiple accounts with the same email, but I'm pretty sure that's disallowed for GPG and SSH keys, at least.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants