Add no_std support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on @termoshtt's rust-num#15, without the intrusive file splitting. I also addressed the other review comments I had left there. The limitations of `no_std` are the missing implementations of `Error` and methods based on `Float`, although `FloatCore` is now used for a few things. Format widths are also not supported, as I couldn't find a way to do this without using a temporary `String`. Co-authored-by: Toshiki Teramura <toshiki.teramura@gmail.com>
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
May 12, 2018
22: Add no_std support r=cuviper a=cuviper Based on @termoshtt's #15, without the intrusive file splitting. I also addressed the other review comments I had left there. The limitations of `no_std` are the missing implementations of `Error` and methods based on `Float`, although `FloatCore` is now used for a few things. Format widths are also not supported, as I couldn't find a way to do this without using a temporary `String`. Fixes #6. Closes #15. Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @termoshtt's #15, without the intrusive file splitting. I also
addressed the other review comments I had left there. The limitations
of
no_stdare the missing implementations ofErrorand methods basedon
Float, althoughFloatCoreis now used for a few things. Formatwidths are also not supported, as I couldn't find a way to do this
without using a temporary
String.Fixes #6.
Closes #15.