Create ComplexFloat trait to model Floats as a subset of Complex<T> #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you want it you could add a |
|
I will certainly do so. Thanks! |
…point and complex numbers. Added a couple of methods to Complex that were present in Float but missing in Complex. Added tests for many methods on the new trait and for all new methods on Complex. Resolves rust-num#2. Authored originally by Martin Reboredo <yakoyoku@gmail.com> Updated by Josiah Bills <josiah@adoniram.net>
|
Ping, any chance I could get a review before end of year? |
|
Bump |
cuviper
reviewed
Apr 26, 2022
…ealing ComplexFloat.
|
Awesome work, I'm happy this trait comes alive. |
|
I tweaked a few more things, but I think we're good. 🤞 Thanks! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2. Replaces #53. Nearly all the work here was already done by YakoYakoYokuYoku. I have merely updated it to master and made a few discretionary changes which I think improve the work slightly. More unit tests will be coming.