slightly reduce op-assign clones

rust-num · Jan 26, 2018 · 5869894 · 5869894
1 parent 2b1a4cd
commit 5869894
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/lib.rs b/src/lib.rs
@@ -372,7 +372,8 @@ mod opassign {
 
     impl<T: Clone + Integer + NumAssign> AddAssign for Ratio<T> {
         fn add_assign(&mut self, other: Ratio<T>) {
-            self.numer = (self.numer.clone() * other.denom.clone()).add(self.denom.clone() * other.numer);
+            self.numer *= other.denom.clone();
+            self.numer += self.denom.clone() * other.numer;
             self.denom *= other.denom;
             self.reduce();
         }
@@ -396,15 +397,17 @@ mod opassign {
 
     impl<T: Clone + Integer + NumAssign> RemAssign for Ratio<T> {
         fn rem_assign(&mut self, other: Ratio<T>) {
-            self.numer = (self.numer.clone() * other.denom.clone()).rem(self.denom.clone() * other.numer);
+            self.numer *= other.denom.clone();
+            self.numer %= self.denom.clone() * other.numer;
             self.denom *= other.denom;
             self.reduce();
         }
     }
 
     impl<T: Clone + Integer + NumAssign> SubAssign for Ratio<T> {
         fn sub_assign(&mut self, other: Ratio<T>) {
-            self.numer = (self.numer.clone() * other.denom.clone()).sub(self.denom.clone() * other.numer);
+            self.numer *= other.denom.clone();
+            self.numer -= self.denom.clone() * other.numer;
             self.denom *= other.denom;
             self.reduce();
         }