Update serde to 1.0 and remove rustc-serialize #24
Conversation
| [dependencies.serde] | ||
| optional = true | ||
| version = ">= 0.7.0, < 0.9.0" | ||
| version = "1.0.0" |
There was a problem hiding this comment.
Does it still work if you add default-features = false?
I think we need that for proper no-std support.
There was a problem hiding this comment.
It does. serde's Cargo.toml states that it's default std feature is for implementations of some std types. That doesn't touch our trait impls.
Should our std feature also activate serde's? I don't think we need to, because we don't depend on it ourselves. I don't know if someone can depend purely transitively on no_std serde but then also need to serialize std types.
There was a problem hiding this comment.
Right, I don't think we need to enable serde/std at all here. Features are additive, so if something else enables serde/std, like num-bigint, then serde will have std overall.
|
I amended the |
|
Thanks! bors r+ |
Build succeeded |
Fixes #9