Add inplace methods to Zero and One
#104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
requested changes
Mar 6, 2019
There was a problem hiding this comment.
I like the idea, but not the name. Usually to_X() would be an immutable &self method returning a derived value. Since you've documented these as "Sets self to ...", I think set_zero and set_one would be better names. Another option with Rust precedent is make_zero and make_one.
|
@cuviper I looked at the guidelines and think that |
|
I also changed the functions to not return |
cuviper
approved these changes
Mar 28, 2019
src/identities.rs
Outdated
| @@ -20,6 +19,12 @@ pub trait Zero: Sized + Add<Self, Output = Self> { | |||
| // This cannot be an associated constant, because of bignums. | |||
| fn zero() -> Self; | |||
|
|
|||
| /// Sets `self` to the additive identity element of `Self`, `0`. | |||
| /// Returns `&mut self` to enable method chaining. | |||
There was a problem hiding this comment.
Suggested change
| /// Returns `&mut self` to enable method chaining. |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Mar 28, 2019
104: Add inplace methods to `Zero` and `One` r=cuviper a=lcnr
Adds the following default implemented methods to `Zero` and `One`:
```rust
fn set_zero(&mut self) {
*self = Zero::zero();
}
```
```rust
fn set_one(&mut self) {
*self = One::one();
}
```
This allows for reuse of BigNums.
Co-authored-by: lcnr/Bastian Kauschke <bastian_kauschke@hotmail.de>
Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following default implemented methods to
ZeroandOne:This allows for reuse of BigNums.