Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard library for float from_str_radix with radix 10 #201

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

tspiteri
Copy link
Contributor

@tspiteri tspiteri commented Feb 5, 2021

Fixes #198.

While at it, also make parsing of the "-NaN" string match the standard library.

@tspiteri
Copy link
Contributor Author

tspiteri commented Feb 5, 2021

#198 (comment) says "it would be nicer to improve this for all bases", but that is a lot of work with basically zero usefulness, which is the reason from_str_radix was removed from the standard library floating-point numbers.

@cuviper
Copy link
Member

cuviper commented Mar 1, 2021

Thanks!

@bors r+

@cuviper
Copy link
Member

cuviper commented Mar 1, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 2, 2021

@bors bors bot merged commit 9c8f20e into rust-num:master Mar 2, 2021
@tspiteri tspiteri deleted the float-radix10 branch April 15, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rounding error with f64::from_str_radix
2 participants