Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"std" feature #24

Closed
wants to merge 3 commits into from
Closed

"std" feature #24

wants to merge 3 commits into from

Conversation

termoshtt
Copy link
Contributor

Copy of "next" branch in num
A clone of the original PR rust-num/num#296 with some fixes in ci/
Ref #16

@cuviper
Copy link
Member

cuviper commented Jan 13, 2018

I appreciate your initiative, but I was hoping to do this in a way that preserves some authorship from before. I also don't want to include breaking changes like One::is_one yet, and I'm reconsidering my former reviews in rust-num/num#296 where I suggested #[cfg] on methods and said:

We should probably also add a caution in the docs for implementors of Float. Those that implement it normally are fine, but if someone now chooses to implement Float only for no_std, their build will fail if anyone else in the entire dependency graph enables num-traits/std.

In retrospect, this seems like something that will inevitably blow up. Maybe their original BaseFloat idea was enough, or some variation like the Real in #23. I'm tempted to just make Float depend on std with no baser alternative at all for now, and we can add something back in later.

@termoshtt
Copy link
Contributor Author

but I was hoping to do this in a way that preserves some authorship from before

Your are quite right. I close this PR, and read the origitnal PR more carefully...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants