Avoid as casts in default FromPrimitive methods
#73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly, the default `from_f64` used `n as i64`, which has undefined behavior on overflow, kind of defeating the purpose here. Now we use a checked `to_i64()` for this, and even try `to_u64()` as a fallback for completeness. (All of the primitive implementations already do better, at least.)
In `to_f64()`, we also try `to_u64()` if `to_i64()` failed.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jun 20, 2018
73: Avoid `as` casts in default FromPrimitive methods r=cuviper a=cuviper Particularly, the default `from_f64` used `n as i64`, which has undefined behavior on overflow, kind of defeating the purpose here. Now we use a checked `to_i64()` for this, and even try `to_u64()` as a fallback for completeness. Also make similar changes to default `ToPrimitive`, but at least it didn't have the same casting problem. Co-authored-by: Josh Stone <cuviper@gmail.com>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Particularly, the default
from_f64usedn as i64, which hasundefined behavior on overflow, kind of defeating the purpose here.
Now we use a checked
to_i64()for this, and even tryto_u64()as afallback for completeness.
Also make similar changes to default
ToPrimitive, but at least itdidn't have the same casting problem.